# allow LVM to lock the filesystem during snapshot creation, so the # FS can flush pending changes and put things into a consistent state. # # includes small fix to current reiserfs support, forcing a transaction # commit during the lock. # # This patch should be applied *AFTER* the generated LVM 1.0 patch. # diff -Nru a/drivers/md/lvm.c b/drivers/md/lvm.c --- a/drivers/md/lvm.c Tue Aug 21 23:55:59 2001 +++ b/drivers/md/lvm.c Tue Aug 21 23:55:59 2001 @@ -219,9 +219,7 @@ #define DEVICE_OFF(device) #define LOCAL_END_REQUEST -/* lvm_do_lv_create calls fsync_dev_lockfs()/unlockfs() */ -/* #define LVM_VFS_ENHANCEMENT */ +#define LVM_VFS_ENHANCEMENT - #include #include diff -Nru a/fs/buffer.c b/fs/buffer.c --- a/fs/buffer.c Tue Aug 21 23:55:59 2001 +++ b/fs/buffer.c Tue Aug 21 23:55:59 2001 @@ -350,6 +350,34 @@ fsync_dev(dev); } +int fsync_dev_lockfs(kdev_t dev) +{ + /* you are not allowed to try locking all the filesystems + ** on the system, your chances of getting through without + ** total deadlock are slim to none. + */ + if (!dev) + return fsync_dev(dev) ; + + sync_buffers(dev, 0); + + lock_kernel(); + /* note, the FS might need to start transactions to + ** sync the inodes, or the quota, no locking until + ** after these are done + */ + sync_inodes(dev); + DQUOT_SYNC(dev); + /* if inodes or quotas could be dirtied during the + ** sync_supers_lockfs call, the FS is responsible for getting + ** them on disk, without deadlocking against the lock + */ + sync_supers_lockfs(dev) ; + unlock_kernel(); + + return sync_buffers(dev, 1) ; +} + asmlinkage long sys_sync(void) { fsync_dev(0); diff -Nru a/fs/reiserfs/super.c b/fs/reiserfs/super.c --- a/fs/reiserfs/super.c Tue Aug 21 23:55:59 2001 +++ b/fs/reiserfs/super.c Tue Aug 21 23:55:59 2001 @@ -66,7 +66,7 @@ reiserfs_prepare_for_journal(s, SB_BUFFER_WITH_SB(s), 1); journal_mark_dirty(&th, s, SB_BUFFER_WITH_SB (s)); reiserfs_block_writes(&th) ; - journal_end(&th, s, 1) ; + journal_end_sync(&th, s, 1) ; } s->s_dirt = dirty; unlock_kernel() ; diff -Nru a/fs/super.c b/fs/super.c --- a/fs/super.c Tue Aug 21 23:55:59 2001 +++ b/fs/super.c Tue Aug 21 23:55:59 2001 @@ -637,6 +637,18 @@ sb->s_op->write_super(sb); unlock_super(sb); } + +static inline void write_super_lockfs(struct super_block *sb) +{ + lock_super(sb); + if (sb->s_root && sb->s_op) { + if (sb->s_dirt && sb->s_op->write_super) + sb->s_op->write_super(sb); + if (sb->s_op->write_super_lockfs) + sb->s_op->write_super_lockfs(sb); + } + unlock_super(sb); +} /* * Note: check the dirty flag before waiting, so we don't @@ -670,6 +682,48 @@ } else sb = sb_entry(sb->s_list.next); spin_unlock(&sb_lock); +} + +/* + * Note: don't check the dirty flag before waiting, we want the lock + * to happen every time this is called. dev must be non-zero + */ +void sync_supers_lockfs(kdev_t dev) +{ + struct super_block * sb; + + if (dev) { + sb = get_super(dev); + if (sb) { + write_super_lockfs(sb); + drop_super(sb); + } + } +} + +void unlockfs(kdev_t dev) +{ + struct super_block * sb; + + if (dev) { + /* we cannot lock the super here because someone + ** might be waiting on the unlock with the + ** super already locked + ** + ** so, we grab the mount semaphore instead, we have + ** to make sure nobody is mounting during our + ** unlock operation. The FS won't unmount because it + ** was locked. + */ + down(&mount_sem); + sb = get_super(dev); + if (sb) { + if (sb->s_op && sb->s_op->unlockfs) + sb->s_op->unlockfs(sb) ; + drop_super(sb); + } + up(&mount_sem); + } } /** diff -Nru a/include/linux/fs.h b/include/linux/fs.h --- a/include/linux/fs.h Tue Aug 21 23:55:59 2001 +++ b/include/linux/fs.h Tue Aug 21 23:55:59 2001 @@ -1223,6 +1223,7 @@ extern void write_inode_now(struct inode *, int); extern void sync_dev(kdev_t); extern int fsync_dev(kdev_t); +extern int fsync_dev_lockfs(kdev_t); extern int fsync_super(struct super_block *); extern int fsync_no_super(kdev_t); extern void sync_inodes_sb(struct super_block *); @@ -1232,6 +1233,8 @@ extern void filemap_fdatasync(struct address_space *); extern void filemap_fdatawait(struct address_space *); extern void sync_supers(kdev_t); +extern void sync_supers_lockfs(kdev_t); +extern void unlockfs(kdev_t); extern int bmap(struct inode *, int); extern int notify_change(struct dentry *, struct iattr *); extern int permission(struct inode *, int); diff -Nru a/kernel/ksyms.c b/kernel/ksyms.c --- a/kernel/ksyms.c Tue Aug 21 23:55:59 2001 +++ b/kernel/ksyms.c Tue Aug 21 23:55:59 2001 @@ -178,6 +178,8 @@ EXPORT_SYMBOL(invalidate_inode_pages); EXPORT_SYMBOL(truncate_inode_pages); EXPORT_SYMBOL(fsync_dev); +EXPORT_SYMBOL(fsync_dev_lockfs); +EXPORT_SYMBOL(unlockfs); EXPORT_SYMBOL(fsync_no_super); EXPORT_SYMBOL(permission); EXPORT_SYMBOL(vfs_permission);